docs: add reference to Fastly's runtime #5370
Conversation
|
|
Hi @harmony7, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
…Fastly adapter to it
harmony7
force-pushed
the
harmony7/fastly-runtime-adapter-doc
branch
from
ed5de24
to
3b36d21
Compare
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
machour
changed the title
MichaelDeBoey
changed the title
There was a problem hiding this comment.
Thanks for adding a reference to Fastly's adapter/runtime/template @harmony7! 🙏
I do have some concerns though, so leaving those to the team to decide on.
|
@MichaelDeBoey @machour have made updates:
|
harmony7
requested review from
MichaelDeBoey
and removed request for
brophdawg11 and
mcansh
|
@MichaelDeBoey oof, I re-requested review from you and I didn't realize that would remove the requests for @brophdawg11 and @mcansh. can you add them back in? |
harmony7
changed the title
|
@MichaelDeBoey bump I've already gotten one approval, but can I get a re-review from you? What else is needed to get this merged? It would be very nice to be added to the list. =) |
Now that #4841 has been merged, it will be possible to use Fastly's runtime/adapter/templates on the next release. Thanks all.
As suggested in #4860 (comment), I've made a new PR that adds Fastly's adapter to docs as a community contribution.
These are docs-only, so it's been branched from the main branch.
EDIT: I've removed the docs updates about the runtime / template, this PR is about the adapter only.